Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Fix "[email protected]": The engine "node" is incompaible with this module. #2679

Merged
merged 1 commit into from Dec 14, 2018
Merged

Fix "[email protected]": The engine "node" is incompaible with this module. #2679

merged 1 commit into from Dec 14, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 14, 2018

This is a very small fix that prevents yarn from aborting the installation on
newer versions of NodeJS. It is merely a temporary fix; the real fix should be
to upgrade all of the dependencies.

Closes #2430.

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #2679 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2679   +/-   ##
=======================================
  Coverage   45.78%   45.78%           
=======================================
  Files         361      361           
  Lines       14630    14630           
  Branches     1924     1924           
=======================================
  Hits         6699     6699           
  Misses       7701     7701           
  Partials      230      230

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77d4f0...e83e155. Read the comment docs.

@bryphe
Copy link
Member

bryphe commented Dec 14, 2018

Thanks for cleaning this up, @samvv ! Looks good to me 👍

@bryphe bryphe merged commit 3c1ef98 into onivim:master Dec 14, 2018
@bryphe
Copy link
Member

bryphe commented Dec 14, 2018

It is merely a temporary fix; the real fix should be to upgrade all of the dependencies.

Definitely!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn install fails with node v10.6.0
2 participants